-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add type annotations to text_mobject.py
#4381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations to text_mobject.py
#4381
Conversation
Error count: 156
# Conflicts: # manim/camera/camera.py # manim/mobject/svg/svg_mobject.py # manim/mobject/text/code_mobject.py # manim/mobject/text/numbers.py # manim/mobject/text/tex_mobject.py # manim/mobject/types/image_mobject.py # mypy.ini
# Conflicts: # mypy.ini
# Conflicts: # manim/mobject/text/text_mobject.py # mypy.ini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left some comments and requests:
# Conflicts: # manim/mobject/text/text_mobject.py # manim/utils/color/core.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left two more comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview: What does this pull request change?
Reviewer Checklist